WWSTCERT-7864 Add shelly wave motion driver #2381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greens
reviewed
Sep 12, 2025
drivers/SmartThings/zwave-sensor/profiles/shelly-wave-motion.yml
Outdated
Show resolved
Hide resolved
greens
reviewed
Sep 12, 2025
Comment on lines
33
to
52
| local function notification_report_handler(self, device, cmd) | ||
| local event | ||
| if cmd.args.notification_type == Notification.notification_type.HOME_SECURITY then | ||
| if cmd.args.event == Notification.event.home_security.STATE_IDLE then | ||
| device:emit_event(capabilities.motionSensor.motion.inactive()) | ||
| elseif cmd.args.event == Notification.event.home_security.MOTION_DETECTION then | ||
| event = capabilities.motionSensor.motion.active() | ||
| end | ||
| end | ||
|
|
||
| if event ~= nil then | ||
| device:emit_event(event) | ||
| end | ||
| end | ||
|
|
||
| local function sensor_multilevel_report_handler(self, device, cmd) | ||
| if cmd.args.sensor_type == SensorMultilevel.sensor_type.LUMINANCE then | ||
| device:emit_event(capabilities.illuminanceMeasurement.illuminance({value = cmd.args.sensor_value, unit = "lux"})) | ||
| end | ||
| end |
There was a problem hiding this comment.
I believe all of these are covered by our defaults and shouldn't have required any code changes, but you could use a test to verify.
There was a problem hiding this comment.
Tested and fixed in 4541c11
Co-authored-by: Steven Green <[email protected]>
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 70 files 451 suites 0s ⏱️ Results for commit d9d911c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d9d911c |
greens
reviewed
Sep 16, 2025
There was a problem hiding this comment.
this file no longer does anything and should be removed
greens
reviewed
Sep 18, 2025
| lazy_load_if_possible("wakeup-no-poll"), | ||
| lazy_load_if_possible("apiv6_bugfix") | ||
| lazy_load_if_possible("apiv6_bugfix"), | ||
| lazy_load_if_possible("shelly-wave-motion") |
There was a problem hiding this comment.
the file referenced here does not exist
greens
approved these changes
Sep 19, 2025
greens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests